-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: change data-test-id to data-test in FlashProvider #13304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13304 +/- ##
===========================================
- Coverage 77.15% 58.13% -19.02%
===========================================
Files 866 480 -386
Lines 45005 16003 -29002
Branches 5357 4130 -1227
===========================================
- Hits 34723 9304 -25419
+ Misses 10159 6699 -3460
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
CI for #13220 passed before #13292 was merged. Then both PRs are merged without rerunning the CI. Now tests in
master
is broken.This adapts the tests in #13220 to the new configuration updated by #13292
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
No visible changes to users. CI should pass.
ADDITIONAL INFORMATION