[explore-v2] make chart container work with existing visualization files #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,28 +3,63 @@ import { connect } from 'react-redux'; | |||
| import { Panel } from 'react-bootstrap'; | |||
| import TimeSeriesLineChart from './charts/TimeSeriesLineChart'; | |||
| import moment from 'moment'; | |||
| import nvd3Vis from '../../../visualizations/nvd3_vis'; | |||
There was a problem hiding this comment.
To generalize here you'll be able to import the object that maps the visualization type string to the object, it's in ../../../visualizations/nvd3_vis
| return this.props.vizType === 'line'; | ||
| renderVis() { | ||
| const slice = this.getMockedSliceObject(); | ||
| nvd3Vis(slice).render(); |
There was a problem hiding this comment.
then here use: vizMap[vizType](slice).render()
ascott
changed the title
ascott
changed the title
|
@mistercrunch added support to use the mapping from vis type to vis file. i removed some components I had duplicated in explorev2, and also removed the new line chart in favor of using the existing viz files. i added an issue documenting the outstanding issues with wrapping the vis's in V2 and will make another PR with fixes for those. #1341. PTAL! |
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ChartContainer />use existing visualization js files to render charts.todo:
https://github.com/ascott/caravel/blob/master/caravel/assets/visualizations/main.js#L3
nvd3_vismodule---- added an issue documenting all the issues with wrapping vis's in V2. will come back for these in a follow up PR. [explore-v2] issues with wrapping existing viz's in V2 #1341
/exploreV2/ with line, bar, area, pie, bubble, box_plot
cc @mistercrunch @vera-liu