-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Tests, dedicated directory and Storybook for the Badge component #13513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geido Code LGTM. One thing that I noticed is that if I change the values of count
, color
, textColor
and size
in the storybook, nothing happens. Are these properties not being used?
@michael-s-molina some properties are exclusive. For instance, you should not use the property count together with the property text or the property status with color. That is the reason why I added undefined to the options so all the combinations can be tested exclusively. However, if you think there is a better way to achieve that, I'll be happy to revisit. |
Codecov Report
@@ Coverage Diff @@
## master #13513 +/- ##
==========================================
- Coverage 76.96% 72.48% -4.48%
==========================================
Files 930 630 -300
Lines 46278 21707 -24571
Branches 5554 5555 +1
==========================================
- Hits 35619 15735 -19884
+ Misses 10525 5838 -4687
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
apache#13513) * Move to dir and add storybook * Add tests * Remove no-restricted-imports
Moves the Badge component to a dedicated directory in src/components while adding tests and a storybook entry.