Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds storybook and tests to AsyncEsmComponent #13517

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds storybook and tests to AsyncEsmComponent
  • Moves AsyncEsmComponent to its own folder

TEST PLAN

1 - Execute AsyncEsmComponent tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #13517 (f128f36) into master (49eeab6) will decrease coverage by 3.15%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13517      +/-   ##
==========================================
- Coverage   76.05%   72.89%   -3.16%     
==========================================
  Files         913      613     -300     
  Lines       46046    21518   -24528     
  Branches     5505     5590      +85     
==========================================
- Hits        35018    15686   -19332     
+ Misses      10865     5700    -5165     
+ Partials      163      132      -31     
Flag Coverage Δ
cypress 57.50% <ø> (+6.11%) ⬆️
hive ?
javascript 62.87% <7.69%> (-0.04%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/AsyncEsmComponent/AsyncEsmComponent.stories.tsx 0.00% <0.00%> (ø)
...rontend/src/components/AsyncEsmComponent/index.tsx 97.29% <100.00%> (ø)
superset/models/tags.py
superset/views/datasource.py
superset/charts/commands/exceptions.py
superset/reports/notifications/__init__.py
superset/databases/commands/export.py
superset/reports/commands/bulk_delete.py
superset/databases/decorators.py
superset/utils/dates.py
... and 343 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49eeab6...537c639. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG

@pkdotson pkdotson merged commit f0a9dcc into apache:master Mar 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants