feat(filter-set): Filter set history #13529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incubator-superset into filter_bar_actions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
…_to_data_mask � Conflicts: � superset-frontend/package-lock.json � superset-frontend/package.json
…incubator-superset into filter_bar_actions
…incubator-superset into filter_bar_actions
…incubator-superset into filter_bar_actions
…ctions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
…r-superset into filter_set_design_2
…esign_2 � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FiltersHeader.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/Footer.tsx
villebro
reviewed
Mar 9, 2021
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx
Outdated
Show resolved
Hide resolved
villebro
reviewed
Mar 9, 2021
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx
Outdated
Show resolved
Hide resolved
| @@ -66,27 +77,59 @@ type FilterSetsProps = { | |||
| const DEFAULT_FILTER_SET_NAME = t('New filter set'); | |||
|
|
|||
| const FilterSets: React.FC<FilterSetsProps> = ({ | |||
| currentDataMask, | |||
There was a problem hiding this comment.
Would be nice to have these in the same style; below we have dataMaskApplied, maybe this could be dataMaskSelected?
There was a problem hiding this comment.
It's not selected it's applied, because it's different
it can be selected but not applied
|
@simcha90 Thanks so much for the contribution! @amitmiran137 i believe we have cut 1.1 release already. it should make it to the next minor. |
it's still not finished |
1.1 is currently 97 commits/PRs behind master, so it could be quite challenging to cherry this in: https://github.com/apache/superset/tree/1.1 |
villebro
approved these changes
Mar 10, 2021
junlincc
added
the
dashboard:native-filters
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* refactor(native-filters): move data mask to root reducer * refactor: update rest stuff for dataMask * refactor: add ownCrrentState to explore * fix: fix immer reducer * fix: merge with master * refactor: support explore dataMask * refactor: support explore dataMask * docs: add comment * refactor: remove json stringify * fix: fix failed cases * feat: filter bat buttons start * fix: fix CR notes * fix: fix cascade filters * fix: fix CR notes * refactor: add clear all * fix: fix CR notes * fix: fix CR notes * fix: fix CR notes * feat: buttons in filter bar * lint: update imports * feat: add tabs for filter sets * feat: add buttons to filter set * feat: first phase add filter sets * fix: undo FF * refactor: continue filter sets * fix: fix CR notes * refactor: header * fix: fix CR notes * fix: fix CR notes * refactor: continue filter sets * lint: fix lint * refactor: continue filter sets * fix: fix filter bar opening * refactor: continue filter sets * refactor: continue filter sets * refactor: continue filter sets * feat: filters sets history * feat: filters sets history * fix: filter set name * refactor: fix expand filters case * fix: fix CR notes * refactor: filter sets * fix: fix CR notes * refactor: filter sets
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR add history of saved filter sets according https://www.figma.com/proto/Z75uj6W6n0A6nfK3Mvawqi/Dashboard-Filters---P1?node-id=960%3A2246&scaling=min-zoom
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-03-09.at.14.58.32.mov
TEST PLAN
ADDITIONAL INFORMATION