Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get table viz work in explore v2: Added d3 format to mock slice #1353

Merged
merged 2 commits into from
Oct 24, 2016

Conversation

vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Oct 14, 2016

Done:
added d3format function to Slice mock in ChartContainer

Before:
before

After:
screen shot 2016-10-14 at 3 32 49 pm

The Slice (in caravel.js) properties that are used by table viz:

  • .selector
  • .removeFilter() --leaving for Control panel components to handle
  • .addFilter() --leaving for Control panel components to handle
  • .d3format()
  • .container.height() --same as height of mock slice
  • .container.parents('.widget').find('.tooltip').remove() --leaving for Control panel components to handle
  • .container.find('.dataTable').DataTable
  • .container.find('.dataTables_wrapper'), height) --I'm not sure how should we mock container in slice for find() calls since we don't currently have dataTable and dataTables_wrapper? @ascott

@vera-liu vera-liu changed the title Added d3 format to mock slice Get table viz work in explore v2: Added d3 format to mock slice Oct 19, 2016

const propTypes = {
sliceName: PropTypes.string.isRequired,
vizType: PropTypes.string.isRequired,
height: PropTypes.string.isRequired,
sliceContainerId: PropTypes.string.isRequired,
jsonEndpoint: PropTypes.string.isRequired,
column_formats: PropTypes.object,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer camelCase for props

@ascott
Copy link

ascott commented Oct 24, 2016

looks legit pending change to use camelCase for props.

Problem:
table viz was not working in explorev2 due to d3format() not defined in
mock slice.
@vera-liu vera-liu merged commit 19fab6e into apache:master Oct 24, 2016
@vera-liu vera-liu deleted the vliu_table_viz branch November 1, 2016 19:01
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants