Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert/report): switch message content between chart and dashboard #13537

Merged

Conversation

lilykuang
Copy link
Member

SUMMARY

  • when switching dashboard/chart in message content AlertReportModal, it clears dashboard or chat field

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
https://www.loom.com/share/6c410a0354224656aa3200f620c69173

TEST PLAN

ADDITIONAL INFORMATION

@junlincc junlincc added the alert-reports Namespace | Anything related to the Alert & Reports feature label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #13537 (63f1c60) into master (fc36de2) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13537      +/-   ##
==========================================
- Coverage   76.93%   76.92%   -0.02%     
==========================================
  Files         934      934              
  Lines       46310    46310              
  Branches     5647     5645       -2     
==========================================
- Hits        35629    35622       -7     
- Misses      10547    10554       +7     
  Partials      134      134              
Flag Coverage Δ
cypress 57.46% <ø> (-0.01%) ⬇️
hive 80.13% <100.00%> (+0.01%) ⬆️
javascript 62.44% <0.00%> (ø)
mysql ?
postgres ?
presto 80.17% <100.00%> (?)
python 80.86% <100.00%> (-0.03%) ⬇️
sqlite 80.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 56.00% <0.00%> (ø)
superset/reports/schemas.py 98.61% <100.00%> (ø)
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/databases/commands/create.py 82.35% <0.00%> (-9.81%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/mysql.py 89.79% <0.00%> (-2.05%) ⬇️
superset/databases/api.py 90.32% <0.00%> (-1.62%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️
superset/models/core.py 88.01% <0.00%> (-0.55%) ⬇️
superset/common/query_context.py 81.52% <0.00%> (-0.55%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc36de2...847c829. Read the comment docs.

@lilykuang lilykuang merged commit cd2f53e into apache:master Mar 15, 2021
@lilykuang lilykuang deleted the lily/alert-report-switch-chart-dashboard branch March 15, 2021 19:00
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants