feat(filter-set): Update existing filter set #13545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…incubator-superset into filter_bar_actions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
…_to_data_mask � Conflicts: � superset-frontend/package-lock.json � superset-frontend/package.json
…incubator-superset into filter_bar_actions
…incubator-superset into filter_bar_actions
…incubator-superset into filter_bar_actions
…ctions � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
…esign_2 � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FiltersHeader.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/Footer.tsx
…tor-superset into filter_set_update
…pdate � Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSetUnit.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/FilterSets.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/Footer.tsx
villebro
reviewed
Mar 10, 2021
| return ( | ||
| <Wrapper> | ||
| <Title strong>{t('Editing filter set:')}</Title> | ||
| <Title>{filterSets[filterSetId].name}</Title> |
There was a problem hiding this comment.
While this isn't yet in the design, I think it would be a good idea to make the title editable when in edit mode
There was a problem hiding this comment.
may be in next PR, here it will cause refactor some code and move to other files
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/EditSection.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/EditSection.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #13545 +/- ##
==========================================
- Coverage 77.31% 73.56% -3.76%
==========================================
Files 903 603 -300
Lines 45926 21406 -24520
Branches 5624 5641 +17
==========================================
- Hits 35508 15747 -19761
+ Misses 10282 5525 -4757
+ Partials 136 134 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #13545 +/- ##
==========================================
- Coverage 77.31% 73.56% -3.76%
==========================================
Files 903 603 -300
Lines 45926 21406 -24520
Branches 5624 5641 +17
==========================================
- Hits 35508 15747 -19761
+ Misses 10282 5525 -4757
+ Partials 136 134 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…rBar/FilterSets/EditSection.tsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
junlincc
added
the
dashboard:native-filters
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* refactor(native-filters): move data mask to root reducer * refactor: update rest stuff for dataMask * refactor: add ownCrrentState to explore * fix: fix immer reducer * fix: merge with master * refactor: support explore dataMask * refactor: support explore dataMask * docs: add comment * refactor: remove json stringify * fix: fix failed cases * feat: filter bat buttons start * fix: fix CR notes * fix: fix cascade filters * fix: fix CR notes * refactor: add clear all * fix: fix CR notes * fix: fix CR notes * fix: fix CR notes * feat: buttons in filter bar * lint: update imports * feat: add tabs for filter sets * feat: add buttons to filter set * feat: first phase add filter sets * fix: undo FF * refactor: continue filter sets * fix: fix CR notes * refactor: header * fix: fix CR notes * fix: fix CR notes * refactor: continue filter sets * lint: fix lint * refactor: continue filter sets * fix: fix filter bar opening * refactor: continue filter sets * refactor: continue filter sets * refactor: continue filter sets * feat: filters sets history * feat: filters sets history * fix: filter set name * refactor: fix expand filters case * fix: fix CR notes * refactor: filter sets * refactor: filter sets * refactor: filter sets * refactor: filter sets * refactor: update sets * feat: edit filter set * refactor: add warning icon * fix: fix CR notes * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/EditSection.tsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * fix: fix CR notes Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR add option to edit existing filter set according this design: https://www.figma.com/proto/Z75uj6W6n0A6nfK3Mvawqi/Dashboard-Filters---P1?node-id=960%3A1284&scaling=min-zoom
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-03-10.at.12.47.40.mov
TEST PLAN
ADDITIONAL INFORMATION