feat(native-filters): add sort option to select filter #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/native-select-sort
branch
from
6cea01c to
a4ad977
Compare
simcha90
reviewed
Mar 11, 2021
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
villebro
force-pushed
the
villebro/native-select-sort
branch
from
a4ad977 to
e238b18
Compare
simcha90
approved these changes
Mar 11, 2021
villebro
force-pushed
the
villebro/native-select-sort
branch
from
f96befd to
9518a96
Compare
villebro
commented
Mar 11, 2021
| @@ -29,10 +29,10 @@ interface PluginFilterSelectCustomizeProps { | |||
| defaultValue?: (string | number)[] | null; | |||
| currentValue?: (string | number)[] | null; | |||
| enableEmptyFilter: boolean; | |||
| fetchPredicate?: string; | |||
There was a problem hiding this comment.
fetchPredicate is now automatically applied in backend
villebro
force-pushed
the
villebro/native-select-sort
branch
from
9518a96 to
bc28498
Compare
villebro
commented
Mar 11, 2021
Comment on lines
-55
to
+54
| multiSelect: false, | ||
| multiSelect: true, |
There was a problem hiding this comment.
Enabling multiSelect by default to match Filter Box.
nytai
approved these changes
Mar 11, 2021
junlincc
added
the
dashboard:native-filters
|
LGTM ✅ Please merge this PR as soon as all checks pass. 🙏 |
villebro
force-pushed
the
villebro/native-select-sort
branch
from
4f4ba96 to
bc28498
Compare
villebro
force-pushed
the
villebro/native-select-sort
branch
from
6816b0d to
ac72e59
Compare
Codecov Report
@@ Coverage Diff @@
## master #13569 +/- ##
==========================================
- Coverage 77.53% 73.45% -4.09%
==========================================
Files 904 604 -300
Lines 45986 21412 -24574
Branches 5552 5557 +5
==========================================
- Hits 35657 15729 -19928
+ Misses 10195 5548 -4647
- Partials 134 135 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* feat(native-filters): add sort option to select filter * remove from useEffect * disable flaky cypress tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add sort option to native select filter that defaults to true.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The filter config modal:
And the filter itself:
TEST PLAN
Local testing
ADDITIONAL INFORMATION