Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI port in dockerfile set to same port in config #13570

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix: UI port in dockerfile set to same port in config #13570

merged 1 commit into from
Mar 12, 2021

Conversation

iercan
Copy link
Contributor

@iercan iercan commented Mar 11, 2021

SUMMARY

Superset ui port set in dockerfile is wrong. That causes healthcheck fails and ui not work in docker deployments .

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@iercan iercan changed the title UI port in dockerfile set to same port in config fix: UI port in dockerfile set to same port in config Mar 11, 2021
@junlincc junlincc requested a review from craig-rueda March 11, 2021 22:14
craig-rueda
craig-rueda reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there specific deployments that aren't working in this repo, or is this for something you've seen elsewhere?

@iercan
Copy link
Contributor Author

iercan commented Mar 12, 2021

@craig-rueda Compose file in repo works fine since SUPERSET_PORT already redefined in .env file. Problem occurs when you build your own docker-compose. Because image exposes wrong port , you have to define SUPERSET_PORT. I think image should work fine with default environment values.

craig-rueda
craig-rueda approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@craig-rueda craig-rueda merged commit de0c6c9 into apache:master Mar 12, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@iercan
Given port in dockerfile set to same port in config (apache#13570)
045288d
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iercan @craig-rueda @mistercrunch