fix: better handle datasource exceptions #13578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.06% -6.48%
==========================================
Files 904 828 -76
Lines 45986 41460 -4526
Branches 5552 4307 -1245
==========================================
- Hits 35657 29462 -6195
- Misses 10195 11998 +1803
+ Partials 134 0 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbarrett
approved these changes
Mar 15, 2021
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 18, 2021
* fix: handle datasource injected security exception * add tests * fix error text on create update dbs * fix lint * revert create update message * fix test * add sqlalchemy exceptions (cherry picked from commit 1e88408)
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 22, 2021
* fix: handle datasource injected security exception * add tests * fix error text on create update dbs * fix lint * revert create update message * fix test * add sqlalchemy exceptions (cherry picked from commit 1e88408)
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* fix: handle datasource injected security exception * add tests * fix error text on create update dbs * fix lint * revert create update message * fix test * add sqlalchemy exceptions
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes
exploreanddashboardsuperset API endpoints so that they can more gracefully handle exceptions from the engines. A more special case is by using theDB_CONNECTION_MUTATORand raising from there.Previously these endpoint would crash with HTTP 500
ADDITIONAL INFORMATION