feat(explore): Drag and drop UX improvements #13598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13598 +/- ##
==========================================
- Coverage 77.29% 73.16% -4.13%
==========================================
Files 910 607 -303
Lines 46359 21568 -24791
Branches 5633 5703 +70
==========================================
- Hits 35831 15781 -20050
+ Misses 10392 5651 -4741
Partials 136 136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
approved these changes
Mar 13, 2021
| @@ -66,7 +66,8 @@ export default function DndSelectLabel<T, O>( | |||
| <ControlHeader {...props} /> | |||
| </HeaderContainer> | |||
| <DndLabelsContainer canDrop={canDrop} isOver={isOver}> | |||
| {isEmpty(props.values) ? renderPlaceHolder() : props.valuesRenderer()} | |||
| {props.valuesRenderer()} | |||
| {displayGhostButton && renderPlaceHolder()} | |||
There was a problem hiding this comment.
Nit: can we rename renderPlaceHolder to renderGhostButton just to be consistent?
|
This solution is only for intermediate stage. @ktmud When most of the fields become droppable, our control panel would be twice as long to scroll. |
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Create a metric immediately when saved metric is dropped * Display borders around control boxes when metric or column is dragged * Fix imports * Display ghost button * Rename placeholder to ghostButton
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds a few UX improvements to dnd feature implemented in #13575:
In order to test the changes, make sure that
ENABLE_EXPLORE_DRAG_AND_DROPfeature flag is enabledBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-03-12.at.11.43.40.mov
Screen.Recording.2021-03-12.at.16.07.48.mov
TEST PLAN
ADDITIONAL INFORMATION
CC: @villebro @junlincc @zhaoyongjie @ktmud