Get filter box viz working for explore v2 #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We often point Airflow committers to this article bellow. Please take the time to read it as it's nice to have good commit messages (though no need to overdo it!), that makes for easier PR/project management, a good changelog and can even provide context while dealing with merge conflicts. |
vera-liu
force-pushed
the
vliu_filter_viz
branch
2 times, most recently
from
1ee81d1
to
2899087
Compare
11 tasks
ascott
reviewed
Oct 24, 2016
| @@ -42,6 +44,16 @@ class ChartContainer extends React.Component { | |||
|
|
|||
| selector: `#${this.props.sliceContainerId}`, | |||
|
|
|||
| setFilter: () => { | |||
| // set filter according to data in store | |||
There was a problem hiding this comment.
can we add git issues so we know we need to add the logic here and for getFilters once the rest of the controls are done?
|
LGTM |
mock slice object in exploreV2 - filter_box in exploreV2 was broken because containerID and getFilter() were not defined in the mock of slice object
vera-liu
force-pushed
the
vliu_filter_viz
branch
from
d1761c4
to
1edddc5
Compare
|
looks like the tests were passing before merging... what do you think happened? should the revert be merged? |
|
Seems that master was broken when I merged |
12 tasks
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
This was referenced Feb 2, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
Todo:
After:
@ascott