Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default when adding tab_state.hide_left_bar #13603

Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Fix the creation of tab_state.hide_left_bar so that the default value is set in the DDL.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida force-pushed the fix_hide_left_bar_default branch from a33d209 to 8ec1f3c Compare March 12, 2021 19:44
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #13603 (9ace2e6) into master (de0c6c9) will decrease coverage by 9.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13603      +/-   ##
==========================================
- Coverage   80.93%   71.15%   -9.79%     
==========================================
  Files         304      828     +524     
  Lines       24807    41443   +16636     
  Branches        0     4300    +4300     
==========================================
+ Hits        20077    29487    +9410     
- Misses       4730    11956    +7226     
Flag Coverage Δ
cypress 56.73% <100.00%> (?)
hive 80.07% <ø> (ø)
mysql 80.37% <ø> (ø)
postgres 80.42% <ø> (ø)
presto ?
python 80.81% <ø> (-0.12%) ⬇️
sqlite 80.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/views/CRUD/data/database/DatabaseModal.tsx 69.59% <100.00%> (ø)
...set-frontend/src/views/CRUD/data/database/state.ts 100.00% <100.00%> (ø)
superset/db_engine_specs/presto.py 82.84% <0.00%> (-5.86%) ⬇️
superset/models/core.py 88.55% <0.00%> (-0.28%) ⬇️
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx 94.59% <0.00%> (ø)
...rontend/src/filters/components/TimeColumn/types.ts 100.00% <0.00%> (ø)
...et-frontend/src/SqlLab/components/QueryHistory.jsx 50.00% <0.00%> (ø)
...ntend/src/dashboard/components/dnd/handleScroll.ts 38.46% <0.00%> (ø)
...end/src/components/Select/WindowedSelect/index.tsx 100.00% <0.00%> (ø)
...nd/src/dashboard/util/findTabIndexByComponentId.js 85.71% <0.00%> (ø)
... and 518 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0c6c9...ebb457c. Read the comment docs.

@betodealmeida betodealmeida force-pushed the fix_hide_left_bar_default branch from 8ec1f3c to ebb457c Compare March 12, 2021 20:12
@betodealmeida betodealmeida merged commit 4fc41e1 into apache:master Mar 12, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Mar 13, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants