Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link update for report and old alerts deprecations #13607

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

betodealmeida
Copy link
Member

Fix link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #13607 (71e473b) into master (06d6d7f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13607      +/-   ##
==========================================
- Coverage   77.29%   77.28%   -0.01%     
==========================================
  Files         911      911              
  Lines       46367    46367              
  Branches     5693     5605      -88     
==========================================
- Hits        35838    35834       -4     
- Misses      10393    10397       +4     
  Partials      136      136              
Flag Coverage Δ
cypress 56.73% <ø> (-0.03%) ⬇️
hive 80.05% <ø> (ø)
javascript 63.07% <ø> (ø)
mysql 80.35% <ø> (ø)
postgres 80.41% <ø> (ø)
presto 80.08% <ø> (ø)
python 80.91% <ø> (ø)
sqlite 80.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/components/Dashboard.jsx 84.94% <0.00%> (-4.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d6d7f...71e473b. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, you'll need to change the pr title though

@betodealmeida betodealmeida changed the title Update UPDATING.md fix: link in UPDATING.md Mar 13, 2021
@junlincc junlincc changed the title fix: link in UPDATING.md fix: link update for report and old alerts deprecations Mar 14, 2021
@betodealmeida betodealmeida merged commit 714d262 into master Mar 15, 2021
@amitmiran137 amitmiran137 deleted the betodealmeida-patch-1 branch March 29, 2021 18:17
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants