Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Add int and bool regex pattern #13621

Merged
merged 3 commits into from
Mar 17, 2021
Merged

fix(explore): Add int and bool regex pattern #13621

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f86634d
fix postgres regex string for bool and int
nikolagigic Mar 15, 2021
d3aed26
move regex from postgres to bae
nikolagigic Mar 15, 2021
11c8766
move regex from postgres to base
nikolagigic Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset/db_engine_specs/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
GenericDataType.NUMERIC,
),
(
re.compile(r"^integer", re.IGNORECASE),
re.compile(r"^int.*", re.IGNORECASE),
types.Integer(),
GenericDataType.NUMERIC,
),
Expand Down Expand Up @@ -222,7 +222,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
),
(re.compile(r"^time", re.IGNORECASE), types.Time(), GenericDataType.TEMPORAL,),
(
re.compile(r"^boolean", re.IGNORECASE),
re.compile(r"^bool.*", re.IGNORECASE),
types.Boolean(),
GenericDataType.BOOLEAN,
),
Expand Down