feat(native-filters): add temporal support to select filter #13622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13622 +/- ##
==========================================
+ Coverage 72.77% 77.41% +4.63%
==========================================
Files 923 924 +1
Lines 46824 46923 +99
Branches 5746 5758 +12
==========================================
+ Hits 34077 36326 +2249
+ Misses 12531 10461 -2070
+ Partials 216 136 -80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
the
dashboard:native-filters
villebro
force-pushed
the
villebro/native-select-format
branch
from
7a44dc1 to
0c86e5d
Compare
villebro
commented
Mar 18, 2021
| @@ -145,7 +145,7 @@ def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]: | |||
| tt = target_type.upper() | |||
| if tt == utils.TemporalType.DATE: | |||
| return f"TO_DATE('{dttm.date().isoformat()}', 'YYYY-MM-DD')" | |||
| if tt == utils.TemporalType.TIMESTAMP: | |||
| if "TIMESTAMP" in tt or "DATETIME" in tt: | |||
There was a problem hiding this comment.
Previously "TIMESTAMP WITH TIMEZONE" was not being picked up, nor was "DATETIME" (utils.TemporalType needs a good refactor, too, but will leave that to a follow-up PR)
villebro
force-pushed
the
villebro/native-select-format
branch
from
0c86e5d to
6c1899b
Compare
amitmiran137
approved these changes
Mar 18, 2021
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for temporal and boolean options to native filters. To facilitate this, a custom SQLAlchemy type is introduced to handle literal binds using
datetimeobjects. In addition, the select Select filter component implements a formatter to show only the relevant digits of the timestamp -YYYY-MM-DDfor dates, andYYY-MM-DD HH:MM:SSfor hours-seconds and fullYYY-MM-DD HH:MM:SS.MMMMMMfor sub-second timestamps.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Dropdown options for filter on date column:
Dropdown options for filter on datetime column. Notice how the format adapts to only show the date if there are no hours, minutes or seconds:
Dropdown options on boolean column:
A bunch of filters enabled at the same time:
The rendered query:
TEST PLAN
ADDITIONAL INFORMATION