Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Table name and schema are encoded twice during fetching table metadata on SQL Lab page. #13636

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

didva
Copy link
Contributor

@didva didva commented Mar 15, 2021

SUMMARY

Table name and schema are encoded twice during fetching table metadata on SQL Lab page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot from 2021-03-15 23-55-58

TEST PLAN

Tested locally.

closes #13317

ADDITIONAL INFORMATION

  • Has associated
  • Changes UI

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #13636 (32254b0) into master (cd2f53e) will decrease coverage by 3.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13636      +/-   ##
==========================================
- Coverage   76.78%   73.02%   -3.76%     
==========================================
  Files         918      608     -310     
  Lines       46641    21638   -25003     
  Branches     5635     5723      +88     
==========================================
- Hits        35812    15801   -20011     
+ Misses      10684     5701    -4983     
+ Partials      145      136       -9     
Flag Coverage Δ
cypress 56.58% <ø> (+2.71%) ⬆️
hive ?
javascript 63.05% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 63.03% <ø> (+0.20%) ⬆️
...-frontend/src/explore/components/controls/index.js 100.00% <ø> (ø)
...perset-frontend/src/explore/components/Control.tsx 95.45% <100.00%> (+0.21%) ⬆️
...uperset/utils/dashboard_filter_scopes_converter.py
superset/examples/deck.py
superset/dashboards/api.py
superset/datasets/metrics/commands/delete.py
superset/legacy.py
superset/utils/hashing.py
superset/dashboards/dao.py
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335415f...aeb8237. Read the comment docs.

@junlincc junlincc requested a review from betodealmeida March 17, 2021 00:50
@junlincc junlincc added the new:contributor The author is a new contributor label Mar 17, 2021
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@betodealmeida betodealmeida merged commit 72d19b6 into apache:master Mar 17, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
…table metadata on SQL Lab page. (apache#13636)

Co-authored-by: dmitry.mudrov <dmitrym.mudrov@agileengine.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels new:contributor The author is a new contributor size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table name and schema are encoded twice during fetching table metadata on SQL Lab page.
4 participants