Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Make suggested changes related to curl use in CONTRIBUTING.md #13643

Merged
merged 1 commit into from
Mar 17, 2021
Merged

docs: Make suggested changes related to curl use in CONTRIBUTING.md #13643

merged 1 commit into from
Mar 17, 2021

Conversation

slim-patchy
Copy link
Contributor

@slim-patchy slim-patchy commented Mar 16, 2021 •
edited
Loading

SUMMARY

Minor doc changes, adding some suggested instructions regarding curl use with zsh shell instead of bash, which became default for macOS starting with Catalina.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Skipping

TEST PLAN

Skipping

ADDITIONAL INFORMATION

  • Has associated issue: N/A
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@slim-patchy slim-patchy changed the title Make preliminary suggested changes related to curl use to CONTRIBUTING.md docs: Make suggested changes related to curl use in CONTRIBUTING.md Mar 16, 2021
@junlincc junlincc added new:contributor The author is a new contributor doc:developer Developer documentation labels Mar 17, 2021
@srinify srinify merged commit abf2c87 into apache:master Mar 17, 2021
@srinify
Copy link
Contributor

srinify commented Mar 17, 2021

Thanks @slim-patchy for the changes!

@slim-patchy slim-patchy deleted the edit-contributing-for-curl-bit branch March 18, 2021 09:45
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@slim-patchy
Make preliminary suggested changes to CONTRIBUTING.md (apache#13643)
d226238
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinify srinify srinify approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation new:contributor The author is a new contributor size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slim-patchy @srinify @mistercrunch @junlincc