Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slack dashboard has stale charts #13655

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

The Slack dashboard in the examples has 2 charts that show no data, since the time range ("last quarter") is now pointing to stale data. I fixed it by setting "no filter" in these charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot_2021-03-16 Slack Dashboard

After:

Screenshot_2021-03-16 Slack Dashboard(1)

TEST PLAN

Ran superset load-examples and verified the dashboard works (see screenshot above).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #13655 (8c32fbf) into master (21cc495) will decrease coverage by 6.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13655      +/-   ##
==========================================
- Coverage   77.41%   71.13%   -6.29%     
==========================================
  Files         918      835      -83     
  Lines       46673    41726    -4947     
  Branches     5720     4329    -1391     
==========================================
- Hits        36131    29680    -6451     
- Misses      10406    12046    +1640     
+ Partials      136        0     -136     
Flag Coverage Δ
cypress 56.58% <ø> (-0.01%) ⬇️
hive ?
javascript ?
mysql 80.55% <ø> (ø)
postgres 80.61% <ø> (ø)
presto 80.29% <ø> (+<0.01%) ⬆️
python 80.84% <ø> (-0.26%) ⬇️
sqlite 80.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/components/OmniContainer/Omnibar.tsx 0.00% <0.00%> (-100.00%) ⬇️
...frontend/src/components/ErrorMessage/IssueCode.tsx 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 0.00% <0.00%> (-100.00%) ⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/components/ErrorMessage/DatabaseErrorMessage.tsx 0.00% <0.00%> (-94.74%) ⬇️
... and 485 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cc495...8c32fbf. Read the comment docs.

@betodealmeida betodealmeida merged commit 98a26e7 into apache:master Mar 16, 2021
@junlincc junlincc removed the need:merge The PR is ready to be merged label Mar 17, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants