feat(helm): Add optional apt-get install to superset_bootstrap.sh #13678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changes the helm template to make calling both pip and apt-get install conditional on packages/requirements being present.
Allows easy extension of Superset by an end user to include packages that may not be suitable for baseline superset. Also makes testing and iteration a bit faster.
TEST PLAN
In existing superset:master:
Expected output:
#!/bin/sh pip install psycopg2==2.8.5 redis==3.2.1
In PR branch:
Expected output:
#!/bin/sh pip install psycopg2==2.8.5 redis==3.2.1
Now, the changes:
Run:
Expected output:
Finally, removing both lists:
Expected output:
#!/bin/sh
ADDITIONAL INFORMATION