Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): missing parents in directPathToFilter #13691

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Mar 18, 2021

SUMMARY

When removing a chart and saving a dashboard, I hit a bug where the dashboard wouldn't save (layout[componentId] was undefined). After the change the dashboard saved successfully.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #13691 (cdba1bd) into master (adc247b) will decrease coverage by 4.27%.
The diff coverage is 100.00%.

❗ Current head cdba1bd differs from pull request most recent head fa4784e. Consider uploading reports for the commit fa4784e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13691      +/-   ##
==========================================
- Coverage   77.40%   73.12%   -4.28%     
==========================================
  Files         924      612     -312     
  Lines       46863    21743   -25120     
  Branches     5657     5746      +89     
==========================================
- Hits        36272    15899   -20373     
+ Misses      10455     5708    -4747     
  Partials      136      136              
Flag Coverage Δ
cypress 56.58% <100.00%> (ø)
hive ?
javascript 63.15% <0.00%> (ø)
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/dashboard/actions/dashboardState.js 68.87% <100.00%> (ø)
superset/tasks/async_queries.py
superset/dashboards/commands/create.py
superset/utils/feature_flag_manager.py
superset/reports/commands/bulk_delete.py
superset/databases/commands/test_connection.py
superset/charts/commands/create.py
superset/charts/commands/export.py
superset/dashboards/commands/update.py
superset/examples/multiformat_time_series.py
... and 304 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc247b...fa4784e. Read the comment docs.

@villebro villebro merged commit ecfcaea into apache:master Mar 18, 2021
@villebro villebro deleted the villebro/fix-dashboard-state branch March 18, 2021 19:11
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants