test: PropertiesModal #13818
Merged
test: PropertiesModal #13818
+279
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13818 +/- ##
==========================================
+ Coverage 77.54% 78.35% +0.80%
==========================================
Files 934 933 -1
Lines 47249 47281 +32
Branches 5892 5940 +48
==========================================
+ Hits 36641 37046 +405
+ Misses 10464 10091 -373
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx
Show resolved
Hide resolved
| import PropertiesModal from '.'; | ||
|
|
||
| const createProps = () => ({ | ||
| slice: ({ |
There was a problem hiding this comment.
Can you check if you can use some of the mocks available in spec/fixtures? I know that we have some slices and charts already defined there. If something is missing we could increment. We can also use these mocks in fetch results.
There was a problem hiding this comment.
I tried to apply the slice but it didn't work, at least not in a "simple" way...
lyndsiWilliams
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 7, 2021
* Tests for test-PropertiesModal * finish fetchMock to solve conflicts * clean fetchMock
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Tests for test-PropertiesModal * finish fetchMock to solve conflicts * clean fetchMock
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for component PropertiesModal