Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusted tab height #13822

Merged
merged 7 commits into from
Apr 2, 2021
Merged

fix: adjusted tab height #13822

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2aa4e03
adjusted tab height
AAfghahi Mar 26, 2021
ac24e47
Trigger notification
AAfghahi Mar 26, 2021
3d74e4b
adjusted tab height
AAfghahi Mar 26, 2021
e57efe7
Merge branch 'queryScroll' of ssh://github.com/preset-io/superset int…
AAfghahi Mar 26, 2021
347e8db
fixed progress bar
AAfghahi Mar 26, 2021
383d563
changed to static
AAfghahi Mar 30, 2021
bf720a0
better variable names
AAfghahi Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import {
LOCALSTORAGE_MAX_QUERY_AGE_MS,
} from '../../constants';

const TAB_HEIGHT = 64;
const TAB_HEIGHT = 76;

/*
editorQueries are queries executed by users passed from SqlEditor component
Expand Down Expand Up @@ -63,7 +63,7 @@ const StyledPane = styled.div`
flex-direction: column;
}
.tab-content {
overflow: hidden;
height: 100%;
.alert {
margin-top: ${({ theme }) => theme.gridUnit * 2}px;
}
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ body {
position: relative;
background-color: @lightest;
overflow-x: auto;
overflow-y: hidden;
overflow-y: auto;

> .ant-tabs-tabpane {
position: absolute;
Expand Down
5 changes: 5 additions & 0 deletions superset-frontend/src/components/ProgressBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ const ProgressBar = styled(({ striped, ...props }: ProgressBarProps) => (
<AntdProgress {...props} />
))`
line-height: 0;
position: inherit;
.ant-progress-inner {
position: inherit;
}
.ant-progress-outer {
${({ percent }) => !percent && `display: none;`}
}
.ant-progress-text {
font-size: ${({ theme }) => theme.typography.sizes.s}px;
}
.ant-progress-bg {
position: inherit;
Copy link
Member

@eschutho eschutho Mar 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, do you know specifically what this value should be? It would be better to be more explicit if you can on these three position values.

Copy link
Member Author

@AAfghahi AAfghahi Mar 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I don't but I can test it. I think it should probably be absolute or inline-block. That's a very good point, I'll fix it tonight.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eschutho it was static!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

${({ striped }) =>
striped &&
`
Expand Down