-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: working timeout with celery kill and logic fix #13911
fix: working timeout with celery kill and logic fix #13911
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13911 +/- ##
==========================================
+ Coverage 77.83% 79.18% +1.35%
==========================================
Files 934 936 +2
Lines 47320 47427 +107
Branches 5913 5940 +27
==========================================
+ Hits 36831 37555 +724
+ Misses 10346 9745 -601
+ Partials 143 127 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
"Query for %s took %.2f ms", | ||
self._report_schedule.name, | ||
(stop - start) * 1000.0, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a log info with the time a query took to execute
…pache#13911) * fix: working timeout with celery kill and logic fix * add config flags * fix typo * fix python lint * log query time for alerts * add tests * fix lint
…pache#13911) * fix: working timeout with celery kill and logic fix * add config flags * fix typo * fix python lint * log query time for alerts * add tests * fix lint
SUMMARY
Fixes logic for working timeout, adds a Celery Soft time out and an Hard time out associated with the working timeout.
Note: Killing the task does not guarantee the query is canceled on the analytics DB
ADDITIONAL INFORMATION