Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable installing docker/requirements-local.txt in docker-compos… #13926

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Apr 2, 2021

…e-non-dev.yml

SUMMARY

The current service definition for the web app in docker-compose-non-dev.yml uses the default entrypoint for the container which skips over installing the packages listed in docker/requirements-local.txt. This PR fixes that issue by adding another variant to the docker-bootstrap.sh script to run the default entrypoint script after packages have been installed.
Note: setting the user as root is necessary in order to install packages.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • run docker-compose -f docker-compose-non-dev.yml up and confirm:
    • packages listed in docker/requirements-local.txt are installed on container boot
    • the web app is being served by gunicorn.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Could not load database driver: TrinoEngineSpec #13640
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai merged commit 541d23b into apache:master Apr 3, 2021
@nytai nytai deleted the tai/fix-non-dev-docker-compose branch April 4, 2021 22:10
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not load database driver: TrinoEngineSpec
3 participants