Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Tab #13937

Merged
merged 7 commits into from
Apr 9, 2021
Merged

test: Tab #13937

merged 7 commits into from
Apr 9, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Apr 2, 2021

SUMMARY

Tests for Tab component

@codecov
Copy link

codecov bot commented Apr 2, 2021 •
edited
Loading

Codecov Report

Merging #13937 (e2c657a) into master (1d8d067) will increase coverage by 1.76%.
The diff coverage is 89.65%.

❗ Current head e2c657a differs from pull request most recent head 429250d. Consider uploading reports for the commit 429250d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13937      +/-   ##
==========================================
+ Coverage   76.54%   78.30%   +1.76%     
==========================================
  Files         934      936       +2     
  Lines       47393    47385       -8     
  Branches     5964     5967       +3     
==========================================
+ Hits        36276    37107     +831     
+ Misses      10939    10136     -803     
+ Partials      178      142      -36
Flag Coverage Δ
cypress 56.07% <73.17%> (+7.70%) ⬆️
hive ?
javascript 66.89% <92.59%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/components/TableElement.jsx 88.60% <ø> (+0.23%) ⬆️
...end/src/common/components/DropdownButton/index.tsx 24.00% <0.00%> (ø)
...rset-frontend/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
.../components/CrossFilterScopingModal/utils/index.ts 100.00% <ø> (ø)
...src/dashboard/components/PublishedStatus/index.jsx 100.00% <ø> (ø)
...components/controls/FilterBoxItemControl/index.jsx 73.58% <ø> (ø)
...onents/controls/FilterControl/AdhocFilter/index.js 96.92% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 60.00% <ø> (ø)
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 66.00% <ø> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx 77.48% <ø> (ø)
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8d067...429250d. Read the comment docs.

yardz and others added 6 commits April 5, 2021 16:12
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tab.…
5897fcd 
…test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tab.…
de2a723 
…test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tab.…
65ee323 
…test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tab.…
bcba25a 
…test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tab.…
fe142cc 
…test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tab.…
429250d 
…test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
pkdotson
pkdotson approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to go thanks for the tests!

rusackas
rusackas approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 011af82 into apache:master Apr 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: Tab (apache#13937)
461ffcf 
* Tests for Tab component

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@yardz @michael-s-molina
test: Tab (apache#13937)
9e3b689 
* Tests for Tab component

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina requested changes

@pkdotson pkdotson pkdotson approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yardz @rusackas @pkdotson @michael-s-molina @mistercrunch @junlincc