Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Tabs #13941

Merged
merged 3 commits into from
Apr 9, 2021
Merged

test: Tabs #13941

merged 3 commits into from
Apr 9, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Apr 2, 2021

SUMMARY

Test for Tabs component

@codecov
Copy link

codecov bot commented Apr 2, 2021 •
edited
Loading

Codecov Report

Merging #13941 (61c6017) into master (1d8d067) will increase coverage by 1.39%.
The diff coverage is 88.79%.

❗ Current head 61c6017 differs from pull request most recent head 143a3d4. Consider uploading reports for the commit 143a3d4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13941      +/-   ##
==========================================
+ Coverage   76.54%   77.93%   +1.39%     
==========================================
  Files         934      935       +1     
  Lines       47393    47375      -18     
  Branches     5964     5964              
==========================================
+ Hits        36276    36923     +647     
+ Misses      10939    10295     -644     
+ Partials      178      157      -21
Flag Coverage Δ
javascript 67.24% <90.17%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/components/TableElement.jsx 88.60% <ø> (+0.23%) ⬆️
...end/src/common/components/DropdownButton/index.tsx 24.00% <0.00%> (ø)
...rset-frontend/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
.../components/CrossFilterScopingModal/utils/index.ts 100.00% <ø> (ø)
...src/dashboard/components/PublishedStatus/index.jsx 100.00% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.jsx 77.89% <ø> (ø)
...perset-frontend/src/datasource/DatasourceModal.tsx 72.58% <ø> (ø)
...components/controls/FilterBoxItemControl/index.jsx 73.58% <ø> (ø)
...onents/controls/FilterControl/AdhocFilter/index.js 96.92% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 60.00% <ø> (ø)
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8d067...143a3d4. Read the comment docs.

pkdotson
pkdotson reviewed Apr 3, 2021
View reviewed changes
superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx Outdated
}),
);

const creteProps = () => ({
Copy link
Member

@pkdotson pkdotson Apr 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling nit: createProps
Also why does this need to be a function. There are no paramerters being passed in or reassignments. Does it make sense to make this an object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

We talked about this in another PR: #13753 (comment)

@junlincc
Copy link
Member

junlincc commented Apr 5, 2021

/testenv up

@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/gridComponents/Tabs…
143a3d4 
….test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@junlincc Ephemeral environment spinning up at http://52.38.130.102:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yardz yardz closed this Apr 6, 2021
@yardz yardz reopened this Apr 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

Ephemeral environment shutdown and build artifacts deleted.

pkdotson
pkdotson approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG!

@rusackas rusackas merged commit 1920811 into apache:master Apr 9, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: Tabs (apache#13941)
08daa71 
* Test for Tabs component

* Fix: "creteProps" to "createProps"

* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@yardz @michael-s-molina
test: Tabs (apache#13941)
a819133 
* Test for Tabs component

* Fix: "creteProps" to "createProps"

* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina left review comments

@pkdotson pkdotson pkdotson approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yardz @junlincc @pkdotson @michael-s-molina @mistercrunch @rusackas