Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @superset-ui/plugin-chart-table to 0.17.28 #13953

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 5, 2021

SUMMARY

bump @superset-ui/plugin-chart-table to 0.17.28 to bring in apache-superset/superset-ui#1039

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See apache-superset/superset-ui#1039

TEST PLAN

Manual testing and visual confirmation

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the viz:charts:table Related to the Table chart label Apr 5, 2021
@ktmud
Copy link
Member Author

ktmud commented Apr 5, 2021

Also bump chrono-node so it adds typing. #13797 (comment)

@ktmud ktmud mentioned this pull request Apr 5, 2021
6 tasks
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #13953 (4dfd16b) into master (e062906) will increase coverage by 0.20%.
The diff coverage is 91.66%.

❗ Current head 4dfd16b differs from pull request most recent head b1a383d. Consider uploading reports for the commit b1a383d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13953      +/-   ##
==========================================
+ Coverage   78.08%   78.28%   +0.20%     
==========================================
  Files         934      936       +2     
  Lines       47352    47385      +33     
  Branches     5952     5967      +15     
==========================================
+ Hits        36976    37097     +121     
+ Misses      10232    10146      -86     
+ Partials      144      142       -2     
Flag Coverage Δ
cypress 56.05% <89.47%> (+0.02%) ⬆️
javascript 66.84% <96.87%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/common/components/DropdownButton/index.tsx 24.00% <0.00%> (ø)
...components/controls/FilterBoxItemControl/index.jsx 73.58% <ø> (ø)
...onents/controls/FilterControl/AdhocFilter/index.js 96.92% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 60.00% <ø> (ø)
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 66.00% <ø> (ø)
...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx 77.48% <ø> (ø)
...trol/AdhocFilterEditPopoverSqlTabContent/index.jsx 63.33% <ø> (ø)
...controls/FilterControl/AdhocFilterOption/index.jsx 100.00% <ø> (ø)
...ponents/controls/TimeSeriesColumnControl/index.jsx 100.00% <ø> (ø)
superset/utils/screenshots.py 38.59% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b14dc...b1a383d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@junlincc Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@junlincc Ephemeral environment creation failed. Please check the Actions logs for details.

@nytai
Copy link
Member

nytai commented Apr 5, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@nytai Ephemeral environment spinning up at http://54.184.0.82:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link

@junlin-qa junlin-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally! LGTM thanks for the enhancement. 🙏

I think we should allow user to set the alignment(left, center and right) in the future.

@junlincc junlincc added the need:merge The PR is ready to be merged label Apr 6, 2021
@zhaoyongjie zhaoyongjie merged commit b9e6014 into apache:master Apr 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

Ephemeral environment shutdown and build artifacts deleted.

@junlincc junlincc removed the need:merge The PR is ready to be merged label Apr 6, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
* chore: bump @superset-ui/plugin-chart-table to 0.17.28

* Bump chrono-node
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* chore: bump @superset-ui/plugin-chart-table to 0.17.28

* Bump chrono-node
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* chore: bump @superset-ui/plugin-chart-table to 0.17.28

* Bump chrono-node
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS viz:charts:table Related to the Table chart 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants