Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null exception from adhoc metric popover #13955

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Apr 5, 2021

SUMMARY

This PR is to fix a JS exception, which is specific to druid dataset. When user tried to add/edit Metrics for a druid dataset, JS exception is thrown.

Before
Screen Shot 2021-04-05 at 4 42 43 PM

After
Show adhoc metrics popovers.

TEST PLAN

CI and manual test

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #13955 (9a105f1) into master (9156f08) will increase coverage by 0.81%.
The diff coverage is 92.59%.

❗ Current head 9a105f1 differs from pull request most recent head 2aa1b0b. Consider uploading reports for the commit 2aa1b0b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13955      +/-   ##
==========================================
+ Coverage   77.83%   78.64%   +0.81%     
==========================================
  Files         934      935       +1     
  Lines       47320    47375      +55     
  Branches     5913     5973      +60     
==========================================
+ Hits        36831    37260     +429     
+ Misses      10346     9972     -374     
  Partials      143      143              
Flag Coverage Δ
cypress 56.03% <73.62%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 28.12% <ø> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx 88.60% <ø> (+0.23%) ⬆️
...end/src/common/components/DropdownButton/index.tsx 24.00% <0.00%> (ø)
...rset-frontend/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
.../components/CrossFilterScopingModal/utils/index.ts 100.00% <ø> (ø)
...src/dashboard/components/PublishedStatus/index.jsx 100.00% <ø> (ø)
...dashboard/components/SliceHeaderControls/index.jsx 77.89% <ø> (ø)
...perset-frontend/src/datasource/DatasourceModal.tsx 72.58% <ø> (ø)
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 84.76% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 82.85% <ø> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a2cc3...2aa1b0b. Read the comment docs.

@zhaoyongjie zhaoyongjie closed this Apr 6, 2021
@zhaoyongjie zhaoyongjie reopened this Apr 6, 2021
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 4b29789 into apache:master Apr 6, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants