Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data table z index in sql Editor #13972

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Apr 6, 2021

SUMMARY

Data dropdown was underneath the table and dataset dropdowns. This fixes that.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

after:

image

Screen Shot 2021-04-06 at 12 17 17 PM

Screen Shot 2021-04-06 at 12 16 55 PM

TEST PLAN

visually test places where it is used.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Copy link
Member

eschutho commented Apr 6, 2021

I visual tested and verified that the header dropdown is over the sql lab selections.
🏷 ready-to-merge

@superset-github-bot superset-github-bot bot added the need:merge The PR is ready to be merged label Apr 6, 2021
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@@ -300,7 +300,7 @@ div.Workspace {
.schemaPane-enter-done,
.schemaPane-exit {
transform: translateX(0);
z-index: 1020;
z-index: 7;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have some z-index variables. It would be nice to manage them all in one place:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jesse, but let not block for this enhancement

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #13972 (33aa61b) into master (8b9c142) will increase coverage by 0.69%.
The diff coverage is n/a.

❗ Current head 33aa61b differs from pull request most recent head e1d21df. Consider uploading reports for the commit e1d21df to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13972      +/-   ##
==========================================
+ Coverage   77.87%   78.56%   +0.69%     
==========================================
  Files         935      935              
  Lines       47375    47375              
  Branches     5964     5964              
==========================================
+ Hits        36895    37222     +327     
+ Misses      10323    10010     -313     
+ Partials      157      143      -14     
Flag Coverage Δ
cypress 56.05% <ø> (+5.28%) ⬆️
javascript 67.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 63.26% <0.00%> (+0.20%) ⬆️
.../src/explore/components/ControlPanelsContainer.tsx 97.34% <0.00%> (+0.88%) ⬆️
...nd/src/explore/components/ExploreViewContainer.jsx 77.77% <0.00%> (+1.16%) ⬆️
...et-frontend/src/components/EditableTitle/index.tsx 75.30% <0.00%> (+1.23%) ⬆️
superset-frontend/src/reduxUtils.ts 81.01% <0.00%> (+1.26%) ⬆️
...ntend/src/explore/components/ExploreChartPanel.jsx 82.60% <0.00%> (+1.44%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 92.42% <0.00%> (+1.51%) ⬆️
superset-frontend/src/chart/Chart.jsx 64.81% <0.00%> (+1.85%) ⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 73.58% <0.00%> (+1.88%) ⬆️
...rset-frontend/src/explore/components/SaveModal.tsx 91.20% <0.00%> (+2.19%) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9c142...e1d21df. Read the comment docs.

@hughhhh hughhhh merged commit 7fb1383 into apache:master Apr 6, 2021
@hughhhh hughhhh deleted the sqlLab_table branch April 6, 2021 16:42
@junlincc junlincc removed the need:merge The PR is ready to be merged label Apr 6, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants