-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Data table z index in sql Editor #13972
Conversation
I visual tested and verified that the header dropdown is over the sql lab selections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
@@ -300,7 +300,7 @@ div.Workspace { | |||
.schemaPane-enter-done, | |||
.schemaPane-exit { | |||
transform: translateX(0); | |||
z-index: 1020; | |||
z-index: 7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have some z-index variables. It would be nice to manage them all in one place:
@z-index-max: 3000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Jesse, but let not block for this enhancement
Codecov Report
@@ Coverage Diff @@
## master #13972 +/- ##
==========================================
+ Coverage 77.87% 78.56% +0.69%
==========================================
Files 935 935
Lines 47375 47375
Branches 5964 5964
==========================================
+ Hits 36895 37222 +327
+ Misses 10323 10010 -313
+ Partials 157 143 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit 7fb1383)
SUMMARY
Data dropdown was underneath the table and dataset dropdowns. This fixes that.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
after:
TEST PLAN
visually test places where it is used.
ADDITIONAL INFORMATION