-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pie chart not displayed in viz type selection #13987
fix: Pie chart not displayed in viz type selection #13987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Codecov Report
@@ Coverage Diff @@
## master #13987 +/- ##
==========================================
+ Coverage 78.54% 79.13% +0.58%
==========================================
Files 935 936 +1
Lines 47374 47409 +35
Branches 5956 5943 -13
==========================================
+ Hits 37211 37515 +304
+ Misses 10020 9767 -253
+ Partials 143 127 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM merge!👍 |
@villebro Does this include helm chart fix too? |
don't think so. what is helm chat btw? @Hemant0601 |
Hi, @Hemant0601 |
@zhaoyongjie Yes installtion of superset in kubernetes using helm chart here. https://github.com/apache/superset/tree/master/helm/superset |
@Hemant0601 yes this PR will also fix the problem on helm. |
(cherry picked from commit 56dc74e)
(cherry picked from commit 56dc74e)
SUMMARY
fix can not be displayed chart when some chart support cross filter behavior.
closes: #13962
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TEST PLAN
tested in my local. would be adding more UT/IT for this case in the future.
ADDITIONAL INFORMATION