test: ColumnSelect #13991
Merged
test: ColumnSelect #13991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13991 +/- ##
==========================================
- Coverage 79.21% 79.04% -0.17%
==========================================
Files 936 936
Lines 47408 47408
Branches 5940 5938 -2
==========================================
- Hits 37554 37474 -80
- Misses 9727 9808 +81
+ Partials 127 126 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
michael-s-molina
approved these changes
Apr 7, 2021
|
|
||
| test('Should render', () => { | ||
| const props = createProps(); | ||
| const { container } = render(<ColumnSelect {...(props as any)} />, { |
There was a problem hiding this comment.
Fortunately, ColumnSelect is already in typescript and it has a ColumnSelectProps definition. You can use it anywhere props appear. No blocker, but it would be nicer.
junlincc
added
test:component
dashboard:native-filters
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for ColumnSelect