-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use dynamic time_grains for schema #14009
fix: use dynamic time_grains for schema #14009
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14009 +/- ##
==========================================
- Coverage 79.21% 78.86% -0.36%
==========================================
Files 936 940 +4
Lines 47408 47651 +243
Branches 5940 5998 +58
==========================================
+ Hits 37554 37578 +24
- Misses 9727 9946 +219
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
failed test looks like a connection error.. rerunning. |
front-end check error is an npm timeout, and I ran the
|
🏷 rush! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🏷️ 2021.13 |
(cherry picked from commit 667eb83)
SUMMARY
When testing out TIME_GRAIN_ADDONS from the config, although new time grains are working for line charts, they don't work for table charts:
This PR uses the built in time grains from the db_engine_spec and adds the time_grain_addons from the config to make the schema fields for the charts
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after:
TEST PLAN
I didn't see any unit tests for schemas. It's typically a very static file. I can add a new test if it feels warranted. Otherwise, to manually test, add a new time grain for the selected db and test with different types of charts.
ADDITIONAL INFORMATION