feat(filter-set): Add filterset resource #14015

ofekisr · 2021-04-08T08:15:46Z

SUMMARY

this is the second milestone in the filter set feature.
it is about managing a scope for filter set either Dashboard/User

Dashboard scoped filter sets will be available for all dashboard permitted user and will be maintained with admins dashboard owners
User scoped filter sets will be private for each user separately

implementation:
a subset API of dashboard "/<dashboard_id>/filtersets" for managing a dashboard

notes:
future milestone will deal with sharing and collaborating on filter-sets

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

tests suites
create_api_tests.py
delete_api_tests.py
get_api_tests.py
update_api_tests.py

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- [X ] Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

github-actions · 2021-04-09T03:23:01Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

dpgaspar

First pass, left some comments

superset/dashboards/filter_sets/api.py

github-actions · 2021-04-13T18:41:44Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

github-actions · 2021-04-15T14:53:21Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

github-actions · 2021-04-15T21:08:57Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

github-actions · 2021-04-16T16:02:23Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

villebro

First pass comments

superset/commands/exceptions.py

villebro · 2021-09-07T11:53:20Z

superset/commands/export.py

-    not_found = CommandException
+    not_found: Type[CommandException] = CommandException


Not sure this is needed

superset/common/request_contexed_based.py

superset/dashboards/filter_sets/commands/base.py

superset/models/dashboard.py

superset/migrations/versions/3ebe0993c770_filterset_table.py

superset/models/filter_set.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

github-actions · 2021-09-09T16:47:41Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

villebro

A few quick questions, will review/test more tomorrow

tests/integration_tests/dashboards/filter_sets/conftest.py

github-actions · 2021-09-22T22:10:33Z

⚠️ @ofekisr Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

villebro

LGTM, thanks for all the hard work! Looking forward to the next iteration!

villebro

Oh, I just noticed the migration down revision needs to be updated!

github-actions · 2021-09-23T08:28:24Z

Ephemeral environment shutdown and build artifacts deleted.

stevetracvc · 2021-09-24T17:28:06Z

Crap, I did this myself already (although mine is way more simple/naive). Any idea when the UI might get merged in? My names apparently conflict with these and break Superset, so if it's going to be a while I'll rename all of my stuff, and I might be able to help a bit with the UI.

Thanks!

* Add filterset resource * fix: fix pre-commit * add tests * add tests and fixes based of failures * Fix pre-commit errors * chore init filterset resource under ff constraint * Fix migration conflicts * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * Fix pylint and migrations issues * add tests and fixes based of failures * Fix missing license * fix down revision * update down_revision * fix: update down_revision * chore: add description to migration * fix: type * refactor: is_user_admin * fix: use get_public_role * fix: move import to the relevant location * chore: add openSpec api schema * chore: cover all openspec API * fix: pre-commit and lint * fix: put and post schemas * fix: undo superset_test_config.py * fix: limit filterSetsApi to include_route_methods = {"get_list", "put", "post", "delete"} * renaming some params * chore: add debug in test config * fix: rename database to different name * fix: try to make conftest.py harmless * fix: pre-commit * fix: new down_revision ref * fix: bad ref * fix: bad ref 2 * fix: bad ref 3 * fix: add api in initiatior * fix: open spec * fix: convert name to str to include int usecases * fix: pylint * fix: pylint * Update superset/common/request_contexed_based.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * chore: resolve PR comments * chore: resolve PR comments * chore: resolve PR comments * fix failed tests * fix pylint * Update conftest.py * chore remove BaseCommand to remove abstraction * chore remove BaseCommand to remove abstraction * chore remove BaseCommand to remove abstraction * chore remove BaseCommand to remove abstraction * chore fix migration Co-authored-by: Ofeknielsen <ofek.israel@nieslen.com> Co-authored-by: amitmiran137 <amit.miran@nielsen.com> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Add filterset resource

b7865ad

ofekisr requested a review from a team as a code owner April 8, 2021 08:15

pull-request-size bot added the size/XL label Apr 8, 2021

Merge remote-tracking branch 'upstream/master' into feat/fileter_set

085a9f7

ofekisr marked this pull request as draft April 8, 2021 08:20

fix: fix pre-commit

60ab14f

pull-request-size bot added size/XXL and removed size/XL labels Apr 8, 2021

amitmiran137 changed the title ~~Add filterset resource~~ feat(filter-set): Add filterset resource Apr 8, 2021

ChronicJpk approved these changes Apr 10, 2021

View reviewed changes

Ofeknielsen added 2 commits April 13, 2021 17:15

add tests

8fddfd0

add tests and fixes based of failures

68aa395

amitmiran137 marked this pull request as ready for review April 13, 2021 14:16

dpgaspar reviewed Apr 13, 2021

View reviewed changes

superset/dashboards/filter_sets/api.py Outdated Show resolved Hide resolved

superset/dashboards/filter_sets/api.py Outdated Show resolved Hide resolved

superset/dashboards/filter_sets/api.py Outdated Show resolved Hide resolved

Fix pre-commit errors

9ca86fb

ofekisr closed this Apr 14, 2021

ofekisr reopened this Apr 14, 2021

chore init filterset resource under ff constraint

f292dea

ofekisr closed this Apr 14, 2021

ofekisr reopened this Apr 14, 2021

ofekisr requested a review from amitmiran137 April 14, 2021 12:20

amitmiran137 requested a review from a team April 14, 2021 14:44

Ofeknielsen added 3 commits April 18, 2021 11:32

Merge remote-tracking branch 'upstream/master' into feat/fileter_set

d7e4b7b

Fix migration conflicts

2a782f9

Fix pylint and migrations issues

8cd164e

villebro reviewed Sep 7, 2021

View reviewed changes

Update superset/common/request_contexed_based.py

55dbfa4

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

ofekisr added 6 commits September 13, 2021 14:05

Merge branch 'upstream_master' into feat/fileter_set

a9ea304

chore: resolve PR comments

568b3a5

chore: resolve PR comments

6359817

chore: resolve PR comments

4af6a6a

fix failed tests

fd6deca

fix pylint

4b0a9ed

villebro reviewed Sep 15, 2021

View reviewed changes

tests/integration_tests/dashboards/filter_sets/conftest.py Outdated Show resolved Hide resolved

tests/integration_tests/dashboards/filter_sets/conftest.py Show resolved Hide resolved

ofekisr and others added 5 commits September 19, 2021 11:37

Update conftest.py

d1a5968

chore remove BaseCommand to remove abstraction

e2bf8d7

chore remove BaseCommand to remove abstraction

2d63fe6

chore remove BaseCommand to remove abstraction

2674d9a

chore remove BaseCommand to remove abstraction

414b0c0

villebro approved these changes Sep 23, 2021

View reviewed changes

villebro requested changes Sep 23, 2021

View reviewed changes

ofekisr added 2 commits September 23, 2021 10:02

Merge branch 'upstream_master' into feat/fileter_set

9e7f948

chore fix migration

51e2084

villebro approved these changes Sep 23, 2021

View reviewed changes

amitmiran137 merged commit 84f7614 into apache:master Sep 23, 2021

amitmiran137 deleted the feat/fileter_set branch September 23, 2021 08:28

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(filter-set): Add filterset resource #14015

feat(filter-set): Add filterset resource #14015

ofekisr commented Apr 8, 2021 •

edited by amitmiran137

Loading

github-actions bot commented Apr 9, 2021

dpgaspar left a comment

github-actions bot commented Apr 13, 2021

github-actions bot commented Apr 15, 2021

github-actions bot commented Apr 15, 2021

github-actions bot commented Apr 16, 2021

villebro left a comment

villebro Sep 7, 2021

github-actions bot commented Sep 9, 2021

villebro left a comment

github-actions bot commented Sep 22, 2021

villebro left a comment

villebro left a comment

github-actions bot commented Sep 23, 2021

stevetracvc commented Sep 24, 2021

		not_found = CommandException
		not_found: Type[CommandException] = CommandException

feat(filter-set): Add filterset resource #14015

feat(filter-set): Add filterset resource #14015

Conversation

ofekisr commented Apr 8, 2021 • edited by amitmiran137 Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

github-actions bot commented Apr 9, 2021

dpgaspar left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 13, 2021

github-actions bot commented Apr 15, 2021

github-actions bot commented Apr 15, 2021

github-actions bot commented Apr 16, 2021

villebro left a comment

Choose a reason for hiding this comment

villebro Sep 7, 2021

Choose a reason for hiding this comment

github-actions bot commented Sep 9, 2021

villebro left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 22, 2021

villebro left a comment

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 23, 2021

stevetracvc commented Sep 24, 2021

ofekisr commented Apr 8, 2021 •

edited by amitmiran137

Loading