[sqllab] proper, quoted, select * on the server side #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Oct 21, 2016
| fields = '*' | ||
| table = self.get_table(table_name, schema=schema) | ||
| if show_cols: | ||
| fields = [quote(c.name) for c in table.columns] |
There was a problem hiding this comment.
I believe you wanted to quote reserved works only
There was a problem hiding this comment.
that sqlalchemy function only quotes reserved words
bkyryliuk
reviewed
Oct 21, 2016
| @@ -1990,7 +1993,7 @@ def select_star(self, database_id, table_name): | |||
| return redirect("/tablemodelview/list/") | |||
|
|
|||
| fields = ", ".join( | |||
| [c.name for c in t.columns] or "*") | |||
| [quote(c.name) for c in t.columns] or "*") | |||
There was a problem hiding this comment.
that sqlalchemy function only quotes reserved words
|
LGTM, once test is fixed. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserved words should be properly quoted now, indent is arguably better than before
