Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add health endpoint to WebSocket server #14110

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

benjreinhart
Copy link
Contributor

@benjreinhart benjreinhart commented Apr 13, 2021

SUMMARY

Application servers will need some sort of health check for deployment. This adds a simple endpoint for the purposes of health checks to the WebSocket server.

This endpoint follows the same url/response as the Flask server for health checks.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@robdiciuccio robdiciuccio merged commit 3294f77 into apache:master Apr 15, 2021
@robdiciuccio robdiciuccio deleted the benjreinhart/ws-server-health branch April 15, 2021 16:42
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants