Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves Dropdown to the components folder #14126

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves Dropdown to the components folder.

This work is part of SIP-61

@rusackas @junlincc

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #14126 (2e4b7ae) into master (55bf72a) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e4b7ae differs from pull request most recent head 91363a0. Consider uploading reports for the commit 91363a0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14126   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files         946      946           
  Lines       47985    47985           
  Branches     5962     5962           
=======================================
  Hits        36970    36970           
  Misses      10814    10814           
  Partials      201      201           
Flag Coverage Δ
javascript 72.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 71.77% <ø> (ø)
...uperset-frontend/src/components/Dropdown/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bf72a...91363a0. Read the comment docs.

@junlincc junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label Apr 15, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs rebase.

@michael-s-molina michael-s-molina force-pushed the dropdown-to-components-folder branch 2 times, most recently from f4ae607 to f9b8fcf Compare April 19, 2021 14:20
@rusackas rusackas merged commit 42fb228 into apache:master Apr 20, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels sip:61:folder-org Related to the organization of the folders as of SIP 61 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants