-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): filter set hydration not working #14129
fix(dashboard): filter set hydration not working #14129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0ff37a1
to
7520648
Compare
Codecov Report
@@ Coverage Diff @@
## master #14129 +/- ##
==========================================
+ Coverage 79.63% 79.84% +0.20%
==========================================
Files 944 943 -1
Lines 47871 47749 -122
Branches 6045 6016 -29
==========================================
+ Hits 38121 38123 +2
+ Misses 9629 9507 -122
+ Partials 121 119 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
When loading a dashboard, filter sets were not being loaded (regression introduced by #13306).
AFTER
Currently opening a dashboard with defined filter sets, no filter sets are loaded:
AFTER
When opening a dashboard with two filter sets, the filter sets are now initialized properly:
TEST PLAN
Local testing
ADDITIONAL INFORMATION