Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): filter set hydration not working #14129

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

villebro
Copy link
Member

SUMMARY

When loading a dashboard, filter sets were not being loaded (regression introduced by #13306).

AFTER

Currently opening a dashboard with defined filter sets, no filter sets are loaded:
image

AFTER

When opening a dashboard with two filter sets, the filter sets are now initialized properly:
image

TEST PLAN

Local testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro force-pushed the villebro/fix-hydrate-filter-sets branch from 0ff37a1 to 7520648 Compare April 14, 2021 16:19
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #14129 (f5dec84) into master (cfe927b) will increase coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head f5dec84 differs from pull request most recent head 7520648. Consider uploading reports for the commit 7520648 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14129      +/-   ##
==========================================
+ Coverage   79.63%   79.84%   +0.20%     
==========================================
  Files         944      943       -1     
  Lines       47871    47749     -122     
  Branches     6045     6016      -29     
==========================================
+ Hits        38121    38123       +2     
+ Misses       9629     9507     -122     
+ Partials      121      119       -2     
Flag Coverage Δ
cypress 56.39% <ø> (+0.01%) ⬆️
javascript 70.17% <ø> (+0.48%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/actions/nativeFilters.ts 60.00% <ø> (ø)
.../components/Header/HeaderActionsDropdown/index.jsx 72.36% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 81.02% <ø> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts 79.41% <ø> (ø)
superset/db_engine_specs/redshift.py 93.75% <100.00%> (+6.25%) ⬆️
...-frontend/src/visualizations/presets/MainPreset.js 66.66% <0.00%> (-33.34%) ⬇️
superset/db_engine_specs/presto.py 84.10% <0.00%> (-5.44%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️
superset/connectors/sqla/models.py 88.61% <0.00%> (-1.46%) ⬇️
...dashboard/components/SliceHeaderControls/index.jsx 78.35% <0.00%> (-1.04%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe927b...7520648. Read the comment docs.

@villebro villebro merged commit 68e11cd into apache:master Apr 15, 2021
@villebro villebro deleted the villebro/fix-hydrate-filter-sets branch April 15, 2021 04:23
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Apr 15, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants