feat: invalid DB name error messages (MySQL/Postgres/Redshift) #14146
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14146 +/- ##
==========================================
+ Coverage 79.70% 79.74% +0.03%
==========================================
Files 945 943 -2
Lines 47975 47763 -212
Branches 6082 6016 -66
==========================================
- Hits 38240 38087 -153
+ Misses 9614 9557 -57
+ Partials 121 119 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
changed the title
| @@ -50,6 +50,9 @@ | |||
| TEST_CONNECTION_HOST_DOWN_REGEX = re.compile( | |||
| "Can't connect to MySQL server on '(?P<hostname>.*?)'." | |||
| ) | |||
| TEST_CONNECTION_UNKNOWN_DATABASE_REGEX = re.compile( | |||
| "Unknown database '(?P<database>.*?)'." | |||
| ) | |||
There was a problem hiding this comment.
are these going to be the same errors that we'll hit when "creating" a db? Should we be prefixing them all with "TEST?" or it that too specific?
There was a problem hiding this comment.
would it be better as just connection_ ?
There was a problem hiding this comment.
I'll fix it in the Presto PR
…e#14146) * initial DB custom errors for mysql * added redshift and postgres
mistercrunch
added
🏷️ bot
SUMMARY
Capture the most common error messages in MySQL, and return them to the user. This is used when first making a DB.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Unit test included
ADDITIONAL INFORMATION