Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Enable the new pivot table #14187

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR enables using the new pivot table chart. To use the new pivot table, select "Pivot Table v2" in visualization type modal on Explore view. Until migration is completed, both pivot table plugins will be available. After the migration is done, the legacy pivot table will be removed and the new one will be renamed to "Pivot Table".
The features have been described in apache-superset/superset-ui#1023

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC: @villebro @junlincc

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, exciting to finally be moving away from Pandas rendered html pivot tables!

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #14187 (f8b01af) into master (eadff5f) will increase coverage by 1.32%.
The diff coverage is 85.36%.

❗ Current head f8b01af differs from pull request most recent head 335bc56. Consider uploading reports for the commit 335bc56 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14187      +/-   ##
==========================================
+ Coverage   78.41%   79.73%   +1.32%     
==========================================
  Files         943      945       +2     
  Lines       47722    48028     +306     
  Branches     6042     6137      +95     
==========================================
+ Hits        37419    38293     +874     
+ Misses      10153     9611     -542     
+ Partials      150      124      -26     
Flag Coverage Δ
javascript 70.25% <71.59%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (ø)
...-frontend/src/components/CronPicker/CronPicker.tsx 91.66% <ø> (ø)
...perset-frontend/src/components/CronPicker/index.ts 100.00% <ø> (ø)
...t-frontend/src/components/DropdownButton/index.tsx 24.00% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Switch/index.tsx 100.00% <ø> (ø)
superset-frontend/src/views/CRUD/alert/types.ts 100.00% <ø> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 52.11% <ø> (-24.98%) ⬇️
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 45.65% <ø> (-17.99%) ⬇️
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadff5f...335bc56. Read the comment docs.

@kgabryje kgabryje closed this Apr 16, 2021
@kgabryje kgabryje reopened this Apr 16, 2021
@kgabryje kgabryje closed this Apr 16, 2021
@kgabryje kgabryje reopened this Apr 16, 2021
@kgabryje kgabryje merged commit cab110e into master Apr 16, 2021
@junlincc junlincc added release:note viz:charts:pivot Related to the Pivot Table charts labels Apr 16, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the feat/new-pivot-table branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels release:note size/XS viz:charts:pivot Related to the Pivot Table charts 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants