Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz): add mixed timeseries and radar chart #14197

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

villebro
Copy link
Member

SUMMARY

Adds Mixed Timeseries and Radar Chart from following superset-ui PRs:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Radar Chart:
image

Mixed Timeseries Chart:
image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro changed the title feat(viz): add mixed and radar chart feat(viz): add mixed timeseries and radar chart Apr 16, 2021
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@zhaoyongjie zhaoyongjie self-requested a review April 16, 2021 15:02
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #14197 (6f58985) into master (fe21de3) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6f58985 differs from pull request most recent head 72500b6. Consider uploading reports for the commit 72500b6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14197      +/-   ##
==========================================
- Coverage   79.87%   79.86%   -0.01%     
==========================================
  Files         944      944              
  Lines       47916    47916              
  Branches     6067     6067              
==========================================
- Hits        38272    38270       -2     
- Misses       9520     9522       +2     
  Partials      124      124              
Flag Coverage Δ
cypress 56.31% <ø> (-0.02%) ⬇️
javascript 70.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️
...dashboard/components/SliceHeaderControls/index.jsx 78.35% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe21de3...72500b6. Read the comment docs.

@villebro villebro force-pushed the villebro/radar-mixed-chart branch from 24aa93a to 72500b6 Compare April 16, 2021 15:38
@zhaoyongjie zhaoyongjie merged commit 7e0e9ac into apache:master Apr 16, 2021
@villebro villebro deleted the villebro/radar-mixed-chart branch April 17, 2021 03:50
@lilila
Copy link

lilila commented Jun 22, 2021

thank you for these charts, they look super nice. However, why is it mandatory to have a B query for the mixed time series chart? Could it be possible to leave it empty? @villebro

@villebro
Copy link
Member Author

@lilila the mixed timeseries chart is really just a stripped down version of the main timeseries chart, but with two queries instead of one, and the possibility of separately customizing the charts of the first and second query (e.g. bar on query A, line on query B). So if you only need one query and one chart type, you're best off just using the main timeseries chart.

@lilila
Copy link

lilila commented Jun 22, 2021

@villebro , the new version (mixed time series) just look better ;) . It was also because I notice it is not possible to add annotation on area chart while it seemed possible with the mixed time series chart. One extra thing, it would be nice to have dashed lines in this new plot.
Thank you for your quick answer

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io release:note size/M viz:charts:echarts Related to Echarts 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants