-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viz): add mixed timeseries and radar chart #14197
feat(viz): add mixed timeseries and radar chart #14197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #14197 +/- ##
==========================================
- Coverage 79.87% 79.86% -0.01%
==========================================
Files 944 944
Lines 47916 47916
Branches 6067 6067
==========================================
- Hits 38272 38270 -2
- Misses 9520 9522 +2
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
24aa93a
to
72500b6
Compare
thank you for these charts, they look super nice. However, why is it mandatory to have a B query for the mixed time series chart? Could it be possible to leave it empty? @villebro |
@lilila the mixed timeseries chart is really just a stripped down version of the main timeseries chart, but with two queries instead of one, and the possibility of separately customizing the charts of the first and second query (e.g. bar on query A, line on query B). So if you only need one query and one chart type, you're best off just using the main timeseries chart. |
@villebro , the new version (mixed time series) just look better ;) . It was also because I notice it is not possible to add annotation on area chart while it seemed possible with the mixed time series chart. One extra thing, it would be nice to have dashed lines in this new plot. |
SUMMARY
Adds Mixed Timeseries and Radar Chart from following
superset-ui
PRs:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Radar Chart:
Mixed Timeseries Chart:
TEST PLAN
ADDITIONAL INFORMATION