Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters #14313

Merged
merged 7 commits into from
Apr 27, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 23, 2021

SUMMARY

Adds an Adhoc Filters and Time Picker controls to native filters modal - works with Range and Select filters.
Setting an adhoc filter or a time picker affects what values (or a range of values) can be chosen from a filter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image
image

Screen.Recording.2021-04-26.at.14.45.03.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc @villebro @ktmud

@kgabryje kgabryje marked this pull request as draft April 23, 2021 12:10
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 26, 2021
@kgabryje kgabryje changed the title feat(native-filters): Implement adhoc filters in Range and Select native filters [WIP] feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters [WIP] Apr 26, 2021
@kgabryje kgabryje requested a review from villebro April 26, 2021 10:04
@kgabryje kgabryje marked this pull request as ready for review April 26, 2021 13:58
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #14313 (b2b371c) into master (7ff35df) will decrease coverage by 0.00%.
The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14313      +/-   ##
==========================================
- Coverage   77.18%   77.17%   -0.01%     
==========================================
  Files         954      954              
  Lines       48134    48171      +37     
  Branches     5985     5998      +13     
==========================================
+ Hits        37151    37177      +26     
- Misses      10786    10797      +11     
  Partials      197      197              
Flag Coverage Δ
javascript 72.09% <80.48%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/nativeFilters/FiltersConfigModal/utils.ts 67.56% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 90.43% <77.77%> (-6.12%) ⬇️
...nd/src/components/SupersetResourceSelect/index.tsx 70.00% <100.00%> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 65.21% <100.00%> (ø)
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 75.00% <100.00%> (+1.00%) ⬆️
...nd/src/dashboard/components/nativeFilters/utils.ts 81.08% <100.00%> (+0.52%) ⬆️
...d/src/dashboard/components/FiltersBadge/Styles.tsx 54.05% <0.00%> (-43.25%) ⬇️
superset-frontend/src/dataMask/actions.ts 72.72% <0.00%> (-9.10%) ⬇️
...src/dashboard/components/FiltersBadge/selectors.ts 76.92% <0.00%> (-1.65%) ⬇️
...nents/nativeFilters/FilterBar/FilterSets/index.tsx 76.76% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff35df...b2b371c. Read the comment docs.

@kgabryje kgabryje changed the title feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters [WIP] feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters Apr 26, 2021
@junlincc junlincc self-requested a review April 26, 2021 17:57
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Apr 26, 2021
@kgabryje kgabryje merged commit 20ab086 into apache:master Apr 27, 2021
amitmiran137 pushed a commit that referenced this pull request Apr 28, 2021
…e and Select native filters (#14313)

* Implement adhoc filters in Range and Select native filters

* Add time picker

* Remove additional filters from datamask

* Create separate stylesheet for AdhocFilterControl in native filters

* Rename Time picker to Time range

* Fix columns in AdhocFilter empty when creating a new filter

* Skip flaky test

(cherry picked from commit 20ab086)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…e and Select native filters (apache#14313)

* Implement adhoc filters in Range and Select native filters

* Add time picker

* Remove additional filters from datamask

* Create separate stylesheet for AdhocFilterControl in native filters

* Rename Time picker to Time range

* Fix columns in AdhocFilter empty when creating a new filter

* Skip flaky test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard release:note size/L test:case v1.2 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants