-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): fix error due to anonymous user #14390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14390 +/- ##
==========================================
- Coverage 76.78% 76.54% -0.25%
==========================================
Files 955 955
Lines 48255 48259 +4
Branches 6035 6036 +1
==========================================
- Hits 37055 36941 -114
- Misses 11005 11123 +118
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f9519b2
to
edcc340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review @michael-s-molina ! |
SUMMARY
If a query has been executed by an undefined user or someone that no longer exists in the database, an error is displayed on the SQL Lab history page:
BEFORE
AFTER
TEST PLAN
Local testing
ADDITIONAL INFORMATION