-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Moves messageToasts to the components folder #14431
chore: Moves messageToasts to the components folder #14431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14431 +/- ##
==========================================
- Coverage 76.98% 76.98% -0.01%
==========================================
Files 1007 1006 -1
Lines 54174 54169 -5
Branches 7463 7462 -1
==========================================
- Hits 41708 41703 -5
Misses 12226 12226
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a70fb53
to
83995c7
Compare
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.190.162.86:8080. Credentials are |
83995c7
to
3bf2000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3bf2000
to
313a03c
Compare
313a03c
to
46b6955
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this sitting around. Obviously it needs a big ol' rebase, and there may be a few new instances of messageToasts that also need addressing, but the code that's here now looks perfectly fine to me.
46b6955
to
e4c6faa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it, thanks for cleaning up the code!
Ephemeral environment shutdown and build artifacts deleted. |
* chore: Moves messageToasts to the components folder * Rebases
* chore: Moves messageToasts to the components folder * Rebases
SUMMARY
messageToasts
to thecomponents
folderconstants.ts
This work is part of SIP-61
@rusackas @pkdotson
TEST PLAN
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION