Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves messageToasts to the components folder #14431

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves messageToasts to the components folder
  • Moves related spec files alongside
  • Simplifies folder structure
  • Removes unused constants.ts

This work is part of SIP-61

@rusackas @pkdotson

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #14431 (082eba4) into master (cc1c6c1) will decrease coverage by 0.00%.
The diff coverage is 90.47%.

❗ Current head 082eba4 differs from pull request most recent head e4c6faa. Consider uploading reports for the commit e4c6faa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14431      +/-   ##
==========================================
- Coverage   76.98%   76.98%   -0.01%     
==========================================
  Files        1007     1006       -1     
  Lines       54174    54169       -5     
  Branches     7463     7462       -1     
==========================================
- Hits        41708    41703       -5     
  Misses      12226    12226              
  Partials      240      240              
Flag Coverage Δ
javascript 71.30% <90.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 59.01% <ø> (ø)
superset-frontend/src/SqlLab/components/App.jsx 57.14% <ø> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js 50.00% <ø> (ø)
superset-frontend/src/chart/chartAction.js 50.96% <ø> (ø)
...-frontend/src/components/CopyToClipboard/index.jsx 94.28% <ø> (ø)
...nd/src/components/MessageToasts/ToastContainer.jsx 100.00% <ø> (ø)
...nd/src/components/MessageToasts/ToastPresenter.tsx 100.00% <ø> (ø)
...ents/MessageToasts/getToastsFromPyFlashMessages.js 100.00% <ø> (ø)
...-frontend/src/components/MessageToasts/reducers.js 92.30% <ø> (ø)
...set-frontend/src/components/MessageToasts/types.ts 100.00% <ø> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1c6c1...e4c6faa. Read the comment docs.

@junlincc junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label May 5, 2021
@michael-s-molina michael-s-molina force-pushed the move-message-toasts-to-components-folder branch from a70fb53 to 83995c7 Compare May 5, 2021 11:45
@rusackas
Copy link
Member

rusackas commented May 6, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

@rusackas Ephemeral environment spinning up at http://54.190.162.86:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina force-pushed the move-message-toasts-to-components-folder branch from 83995c7 to 3bf2000 Compare May 6, 2021 11:30
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina force-pushed the move-message-toasts-to-components-folder branch from 3bf2000 to 313a03c Compare May 17, 2021 10:27
@michael-s-molina michael-s-molina force-pushed the move-message-toasts-to-components-folder branch from 313a03c to 46b6955 Compare June 16, 2021 14:46
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this sitting around. Obviously it needs a big ol' rebase, and there may be a few new instances of messageToasts that also need addressing, but the code that's here now looks perfectly fine to me.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, thanks for cleaning up the code!

@michael-s-molina michael-s-molina merged commit 9b17e86 into apache:master Sep 22, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* chore: Moves messageToasts to the components folder

* Rebases
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* chore: Moves messageToasts to the components folder

* Rebases
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels sip:61:folder-org Related to the organization of the folders as of SIP 61 size/L 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants