Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change relationship filter for datasets to relationOneMany #14435

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Apr 30, 2021

SUMMARY

Fixes #14403 since 1 dataset can only be mapped to 1 database

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@yousoph
Copy link
Member

yousoph commented Apr 30, 2021

🏷️ 2021.17

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #14435 (08459a6) into master (b147fa8) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14435      +/-   ##
==========================================
+ Coverage   76.83%   76.92%   +0.08%     
==========================================
  Files         955      955              
  Lines       48059    48059              
  Branches     6034     6034              
==========================================
+ Hits        36928    36969      +41     
+ Misses      10933    10892      -41     
  Partials      198      198              
Flag Coverage Δ
hive 80.74% <ø> (ø)
javascript 71.55% <ø> (ø)
mysql 81.00% <ø> (ø)
postgres 81.04% <ø> (ø)
presto 80.74% <ø> (?)
python 81.57% <ø> (+0.15%) ⬆️
sqlite 80.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 70.55% <ø> (ø)
superset/models/core.py 89.13% <0.00%> (+0.27%) ⬆️
superset/connectors/sqla/models.py 90.07% <0.00%> (+1.45%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+5.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b147fa8...08459a6. Read the comment docs.

@betodealmeida betodealmeida changed the title Change relationship filter for datasets to relationOneMany fix: Change relationship filter for datasets to relationOneMany Apr 30, 2021
@hughhhh hughhhh merged commit efcdc8c into master Apr 30, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request May 3, 2021
* master: (38 commits)
  refactor(native-filters): allow cascading only for filter_select (apache#14441)
  test(maximize-chart): Add tests to maximize chart action (apache#14371)
  fix: fixing mysql error message (apache#14416)
  feat: Logic added to limiting factor column in Query model (apache#13521)
  change relationship (apache#14435)
  fix: bootstrap data permissions (apache#14348)
  fix: parse simple string error message values (apache#14360)
  chore: add stack trace to all calls of logger.error (apache#14382)
  update README with new docs and recordings (apache#14432)
  Renamed impyla from implya in impala.mdx and Renamed PIP package impyla from impala in index.mdx (apache#14425)
  fix(native-filters): fix filter scope error (apache#14426)
  feat: Adding limiting_factor column to Query model (apache#14234)
  feat: Add etag caching to dashboard APIs (apache#14357)
  chore: Moves Card to the components folder (apache#14139)
  feat: Dynamic imports for the Icons component (apache#14318)
  feat: Support env vars configuration for WebSocket server (apache#14398)
  fix: SQLLab role permissions (apache#14372)
  fix(native-filters): always show filters without dataset (apache#14409)
  fix error getting partitionQuery from table.partition (apache#14369)
  refactor: Boostrap to AntD - Tabs (apache#14048)
  ...
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 3, 2021
(cherry picked from commit efcdc8c)
hughhhh added a commit that referenced this pull request May 4, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the fix-datasets-dbs-filter branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.17 size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset List View][filter list] Not able to filter dataset by database
4 participants