-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): fix error message #14651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14651 +/- ##
=======================================
Coverage 77.54% 77.54%
=======================================
Files 958 958
Lines 48541 48541
Branches 5702 5702
=======================================
Hits 37640 37640
Misses 10700 10700
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we should do something about the copy icon position to make sure no overlap with text.... thanks for the fix! @stephenLYZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit 2320bd4)
SUMMARY
🐛 Bug Fix
fix error message on the SQL lab.
Expected behavior: when user click on the copy icon, "SQL Copied!" should show in toast msg, instead of "sorry ......"
BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION