Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): checkbox form control formatting #14701

Merged
merged 3 commits into from
May 19, 2021

Conversation

suddjian
Copy link
Member

SUMMARY

Fixes a recently introduced formatting issue.

Also changed the Field to a Typescriptified function component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2021-05-11 at 10 58 59 AM

After:
Screen Shot 2021-05-18 at 4 42 05 PM

TEST PLAN

On Explore, open up the Edit Dataset modal and go to Settings

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@suddjian suddjian requested a review from nytai May 18, 2021 23:47
@suddjian suddjian changed the title Fix explore checkbox fix(explore): checkbox form control formatting May 18, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #14701 (c78dd77) into master (2320bd4) will decrease coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14701      +/-   ##
==========================================
- Coverage   77.55%   77.54%   -0.02%     
==========================================
  Files         958      959       +1     
  Lines       48550    48608      +58     
  Branches     5703     5734      +31     
==========================================
+ Hits        37654    37693      +39     
- Misses      10696    10714      +18     
- Partials      200      201       +1     
Flag Coverage Δ
javascript 72.51% <81.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/datasource/DatasourceEditor.jsx 66.38% <ø> (ø)
superset-frontend/src/CRUD/Field.tsx 80.00% <80.00%> (ø)
superset-frontend/src/components/Form/FormItem.tsx 100.00% <100.00%> (ø)
...erset-frontend/src/SqlLab/components/ResultSet.tsx 67.31% <0.00%> (-2.69%) ⬇️
...nd/src/explore/components/ExploreActionButtons.tsx 71.73% <0.00%> (-0.61%) ⬇️
superset-frontend/src/explore/constants.ts 100.00% <0.00%> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <0.00%> (ø)
...-frontend/src/SqlLab/components/SouthPane/state.ts 100.00% <0.00%> (ø)
...tend/src/SqlLab/components/SouthPane/SouthPane.tsx 79.54% <0.00%> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 92.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2320bd4...c78dd77. Read the comment docs.

@suddjian suddjian merged commit 152b0d0 into apache:master May 19, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix(explore): add inline option for the field that only gets used in one place

* typescriptify

* unnecessary component wrapping
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix(explore): add inline option for the field that only gets used in one place

* typescriptify

* unnecessary component wrapping
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix(explore): add inline option for the field that only gets used in one place

* typescriptify

* unnecessary component wrapping
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants