-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): checkbox form control formatting #14701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddjian
changed the title
Fix explore checkbox
fix(explore): checkbox form control formatting
May 18, 2021
nytai
approved these changes
May 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #14701 +/- ##
==========================================
- Coverage 77.55% 77.54% -0.02%
==========================================
Files 958 959 +1
Lines 48550 48608 +58
Branches 5703 5734 +31
==========================================
+ Hits 37654 37693 +39
- Misses 10696 10714 +18
- Partials 200 201 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix(explore): add inline option for the field that only gets used in one place * typescriptify * unnecessary component wrapping
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix(explore): add inline option for the field that only gets used in one place * typescriptify * unnecessary component wrapping
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix(explore): add inline option for the field that only gets used in one place * typescriptify * unnecessary component wrapping
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 1.3.0
labels
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a recently introduced formatting issue.
Also changed the Field to a Typescriptified function component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
On Explore, open up the Edit Dataset modal and go to Settings
ADDITIONAL INFORMATION