fix(dashboard): multiple query trigger when native filter enabled #14734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14734 +/- ##
==========================================
- Coverage 77.54% 77.54% -0.01%
==========================================
Files 959 960 +1
Lines 48696 49128 +432
Branches 5743 5902 +159
==========================================
+ Hits 37762 38094 +332
- Misses 10733 10832 +99
- Partials 201 202 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
May 20, 2021
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts
Outdated
Show resolved
Hide resolved
junlincc
added
the
dashboard:native-filters
|
@zhaoyongjie this extra queries issue only happens when filter has |
11 tasks
the extra queries trigger when the filter has the extra queries do not trigger when append new filter values. May-21-2021.16-13-38.mp4 |
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
May 25, 2021
* master: (163 commits) fix(native-filters): Manage default value of filters by superset (apache#14785) fix: Additional ResultSet tests (apache#14741) chore: added BasicParametersMixin to Redshift (apache#14752) fix: make dataset list sort case insensitive (apache#14528) fix: use encodeURIComponent when getting table metadata (apache#14790) fix: ensure engine is outside parameters (apache#14787) database modal should close on connect with tab layout (apache#14771) feat(native-filters): add search all filter options (apache#14710) fix: extra query in Dashboard when native filter enabled (apache#14770) chore: Improves the native filters UI/UX - iteration 2 (apache#14753) fix(native filters): Fix explore state (apache#14779) fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737) feat: Create BigQuery Parameters for DatabaseModal (apache#14721) feat: enable user impersonation in GSheets (apache#14767) fix: add DB should not say it's Postgres (apache#14766) Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762) feat: save database with new dynamic form (apache#14583) fix: save non-parameter DBs (apache#14759) chore: Removes ColorSchemeControl.less (apache#14199) fix(explore): Icons width (apache#14717) ...
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…ache#14734) * fix(dashboard): multiple query trigger when native filter enabled * fix lint * wip
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…bled (apache#14734)" (apache#14762) This reverts commit 88de410.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…ache#14734) * fix(dashboard): multiple query trigger when native filter enabled * fix lint * wip
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…bled (apache#14734)" (apache#14762) This reverts commit 88de410.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…ache#14734) * fix(dashboard): multiple query trigger when native filter enabled * fix lint * wip
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…bled (apache#14734)" (apache#14762) This reverts commit c5d4962.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fix multiple query trigger when native filter has default value
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
#14706
After
dashboard.multiple.query.mp4
TEST PLAN
tested in my local
ADDITIONAL INFORMATION