-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): decouple unittests from integration tests #15473
refactor(tests): decouple unittests from integration tests #15473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15473 +/- ##
==========================================
- Coverage 77.20% 77.01% -0.19%
==========================================
Files 975 975
Lines 50842 50862 +20
Branches 6728 6740 +12
==========================================
- Hits 39251 39171 -80
- Misses 11376 11475 +99
- Partials 215 216 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b3a386b
to
a7c461e
Compare
a7c461e
to
9cec0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a simple folder migration from
tests to tests/integration-tests
as preparation for moving only unittests into separated folders that would be ran differently and will eventually reduce tests run time
LGTM!
Thank you so much for this PR, @ofekisr! I started adding some (proper) unit tests and it's so good to have them run almost instantaneously. |
SUMMARY
unittests should not depend on app_context or any database
so I moved all tests to be under integrations_tests package, and update all ci commands and configurations
as a separate phase and PRs, unittests should move to be under unittests package, and its conftests file will not contain
app_context dependency
note - unused import removed
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION